Small change to Ye(rho) #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 21, 2015 20:52
…ng compile configurations
|
Hi Sherwood, Can we split the ye(rho) out from the nulib changes? Also, regarding the nulib changes, are you sure this is backwards compatible with using a table? nulib.a is not something generated from the current nulibtable directory, rather nulibtable.a is Evan |
|
Hi Evan,
Yeah, I also changed the makefile in the GR1D nulibtable directory to call
the library "nulib.a" instead of "nulibtable.a". It's a hack, since it
doesn't contain the same content as nulib.a produced by NuLib. Let me know
if there is a better way to do it.
If NULIBDIR is not defined, it defaults to building from
GR1D/src/nulibtable and works fine. However, this does not work with
HAVE_MC==1
Sherwood Richers
…On Sat, Sep 9, 2017 at 1:37 AM, evanoconnor ***@***.***> wrote:
Hi Sherwood,
Can we split the ye(rho) out from the nulib changes?
Also, regarding the nulib changes, are you sure this is backwards
compatible with using a table? nulib.a is not something generated from the
current nulibtable directory, rather nulibtable.a is
Evan
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AE54fE_5GnKL41hpYTc6KFUyJxlT_RCmks5sgiQTgaJpZM4PKSPC>
.
|
|
ugh, sent too soon. Anyway, it doesn't work with HAVE_MC==1 because Sedonu
requires more from NuLib than GR1D/src/nulibtable provides.
Sherwood Richers
On Sat, Sep 9, 2017 at 12:05 PM, Sherwood Richers <[email protected]>
wrote:
… Hi Evan,
Yeah, I also changed the makefile in the GR1D nulibtable directory to call
the library "nulib.a" instead of "nulibtable.a". It's a hack, since it
doesn't contain the same content as nulib.a produced by NuLib. Let me know
if there is a better way to do it.
If NULIBDIR is not defined, it defaults to building from
GR1D/src/nulibtable and works fine. However, this does not work with
HAVE_MC==1
Sherwood Richers
On Sat, Sep 9, 2017 at 1:37 AM, evanoconnor ***@***.***>
wrote:
> Hi Sherwood,
>
> Can we split the ye(rho) out from the nulib changes?
>
> Also, regarding the nulib changes, are you sure this is backwards
> compatible with using a table? nulib.a is not something generated from the
> current nulibtable directory, rather nulibtable.a is
>
> Evan
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#12 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AE54fE_5GnKL41hpYTc6KFUyJxlT_RCmks5sgiQTgaJpZM4PKSPC>
> .
>
|
|
Also, I'm not sure what you mean by split out the changes, but you are
welcome to take all or none of the modifications. I'm just offering them in
case you find them useful. And now, in my scatterbrained state, I realize
that I did not sent the MC modifications yet, so my statement about HAVE_MC
is meaningless to you at this point.
Sherwood Richers
On Sat, Sep 9, 2017 at 12:06 PM, Sherwood Richers <[email protected]>
wrote:
… ugh, sent too soon. Anyway, it doesn't work with HAVE_MC==1 because Sedonu
requires more from NuLib than GR1D/src/nulibtable provides.
Sherwood Richers
On Sat, Sep 9, 2017 at 12:05 PM, Sherwood Richers ***@***.***>
wrote:
> Hi Evan,
>
> Yeah, I also changed the makefile in the GR1D nulibtable directory to
> call the library "nulib.a" instead of "nulibtable.a". It's a hack, since it
> doesn't contain the same content as nulib.a produced by NuLib. Let me know
> if there is a better way to do it.
>
> If NULIBDIR is not defined, it defaults to building from
> GR1D/src/nulibtable and works fine. However, this does not work with
> HAVE_MC==1
>
> Sherwood Richers
>
> On Sat, Sep 9, 2017 at 1:37 AM, evanoconnor ***@***.***>
> wrote:
>
>> Hi Sherwood,
>>
>> Can we split the ye(rho) out from the nulib changes?
>>
>> Also, regarding the nulib changes, are you sure this is backwards
>> compatible with using a table? nulib.a is not something generated from the
>> current nulibtable directory, rather nulibtable.a is
>>
>> Evan
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub
>> <#12 (comment)>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AE54fE_5GnKL41hpYTc6KFUyJxlT_RCmks5sgiQTgaJpZM4PKSPC>
>> .
>>
>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the M1 capabilities of the code, I'm not sure you'll keep using Ye(rho), but this fixes a tiny issue I had when reading in Ye(rho) profiles. I also have a commit in there that I got from you as an email attachment (M1 implicit timestepping fix). Github does not see any difference between our codes in that area, so I presume you must have committed the same file yourself.
Additionally, I added the ability to link with NuLib directly. In the future, NuLib could also be added as a submodule (and the nulibtable code here could be removed).